agama-project / agama / 24843831489

73%

master: 83%

Build Type

push

github

Committed by web-flow

Commit Message

feat(web): hint users when no desktop is selected (#3409)

## TL;DR

With this set of changes, the software summary reflects the user's
actual selections instead of showing generic text, including the chosen
desktop and patterns. It helps to detect when no desktop is selected for
products that expect one, preventing accidental command-line-only
installs. Additionally, it fixes incorrect pattern counting and adds
direct navigation from alerts to the relevant settings.

## In details 

After introducing desktop selection capabilities (PR #3396), the
overview page's software summary still displayed generic text regardless
of the user's selection. This made it difficult to quickly determine
whether a desktop environment was selected or how many additional
patterns were chosen.

More importantly, products like openSUSE Tumbleweed and Leap expect
users to select a desktop environment and intentionally do not select
one by default. Skipping this step results in a command-line-only
system, which is rarely what users want. Without clear information,
users might not realize they forgot to pick a desktop.

This PR helps prevent that by adding relevant information in key places,
as agreed in https://github.com/agama-project/agama/discussions/3335. It
reduces the likelihood of users accidentally installing a system without
a desktop due to oversight.

To achieve this, the software summary on the overview page now reflects
the user's selection:

**Short-circuit states (take precedence)**

| Condition |  Value                         | Description     |
|-----------|-------------------------------|-----------------|
| Loading    | skeleton                      | skeleton        |
| Issues    | "Invalid software selection"  | (hidden)        |

**Products with `desktopSelection: "suggested"`**

| Scenario | Value | Description |

|------------------------------------|-----------------------|---------------------------------------------------|
| Nothing selected yet |... (continued)

Coverage Stats

3810 of 6100 branches covered (62.46%)

Branch coverage included in aggregate %.

51 of 52 new or added lines in 5 files covered. (98.08%)

19 existing lines in 2 files now uncovered.

13960 of 18420 relevant lines covered (75.79%)

86.26 hits per line