zalando-incubator / kube-ingress-aws-controller / 24842732153

72%

push

github

worker: prevent SSL policy update loop on shared load balancers (#788)

In
https://github.com/zalando-incubator/kube-ingress-aws-controller/pull/774,
update LB in-place was introduced. However, it was also introducing the
following bug

-> Ingress A has a custom SSL policy
-> Ingress B uses the default SSL policy
-> Since Ingress B doesn't have the annotation we will allow it through
as
`(ingress.HasSSLPolicyAnnotation && l.sslPolicy != ingress.SSLPolicy)`
doesn't apply
-> So we add both ingresses to LB then later override LB SSL policy with
new ingress SSL policy (default one)
Later `inSync` will revert to the old SSL policy and we go into infinite
loop.

Adding the new tag will help keep in-place updates, while blocking
mismatch ingresses from landing on the same LB

Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>

24 of 29 new or added lines in 3 files covered. (82.76%)

2923 of 4087 relevant lines covered (71.52%)

12.43 hits per line