Freegle / Iznik / 5615

72%

master: 70%

Build Type

Pull #232

circleci

Committed by edwh

Commit Message

fix(tests): fix PR #232 CI failures — Playwright 20m timeout + Vitest auth.js ReferenceError

Root causes diagnosed from CI job 5575 (branch test/coverage-go-utils):

1. **Playwright 2/130 tests timed out (20m) — test-reply-flow-existing-user.spec.js 3.1**
   logoutIfLoggedIn called gotoAndVerify('/') with 202500ms timeout three times
   per test. When V8 lazy-compile stalled the first homepage navigation after
   signUpViaHomepage, the try-block timed out at 202500ms, gotoAndVerify's catch
   took another 33750ms for a screenshot, then logoutIfLoggedIn's own catch block
   retried the same 202500ms goto — totalling ~7 min per logout call × 3 calls
   leaving no budget for the actual test logic.

   Fix: replace gotoAndVerify('/') with page.goto(...).catch(() => {}) in the
   cleanup path. Session data is already cleared before the navigation, so a
   failed goto is acceptable. Timeout capped at navigation.default (135s in CI)
   rather than navigation.initial (202.5s). Same change applied in signUpViaHomepage.

2. **Vitest 1/11866 failing — auth store > disableGoogleAutoselect**
   stores/auth.js used `if (window && ...)` which throws ReferenceError when
   window is deleted in post-teardown setTimeout retries. Fix: `if (typeof window
   === 'undefined') return` — same fix already present in master but missing from
   this branch (branch pre-dates the master commit that added it). Also added the
   three disableGoogleAutoselect test cases from master to auth.spec.js.

Go: 1906/1906 ✓  Vitest: 11867/11867 ✓

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Pull Request Pull Request #232: test(coverage): unit tests for utils package — Flex types, Blur, TidyName, Haversine

Coverage Stats

13422 of 20422 branches covered (65.72%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

315 existing lines in 3 files now uncovered.

85409 of 116617 relevant lines covered (73.24%)

22.24 hits per line