Freegle / Iznik / 5611

72%

master: 70%

Build Type

Pull #234

circleci

Committed by edwh

Commit Message

fix(tests): fix PR #234 CI failures — Playwright wrong groupId + Coveralls vitest coverage

Root causes and fixes:

1. Playwright test-modtools-edits-flow (timeout):
   postMessage() picks a group from the postcode area, not necessarily
   testEnv.group.id. Using testEnv.group.id in the Approve API call
   silently updated 0 rows (wrong groupid), leaving collection='Pending',
   which prevented edit review creation and caused the 202.5s timeout.
   Fix: fetch the message first to get actualGroupId, use that in both
   the Approve and PATCH /memberships calls.

2. Playwright test-repost-group-change (wrong group ID 69615 vs 55):
   Used .first() to find rejected message cards, picking stale messages
   from previous CI runs that belonged to group 69615. Fix: target the
   specific rejected message by data-message-id attribute so only the
   message created by this test run is found.

3. Coveralls vitest coverage decrease:
   auth.js disableGoogleAutoselect had 5 uncovered lines (window guard,
   happy-path disableAutoSelect, catch block) and a bare `window`
   reference that throws ReferenceError in SSR / post-teardown contexts.
   Fix: rewrite guard as typeof window === 'undefined' check and add
   3-test describe block covering undefined-window, happy-path, and
   error-catch branches.

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Pull Request Pull Request #234: test(coverage): message package pure-function unit tests (0 → 47 tests)

Coverage Stats

13433 of 20451 branches covered (65.68%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 1 file covered. (100.0%)

339 existing lines in 5 files now uncovered.

96200 of 132809 relevant lines covered (72.43%)

21.47 hits per line