umputun / revdiff / 24824793047

90%

push

github

Mouse wheel and click support in overlay popups (#144)

* feat(ui): route mouse wheel through overlay popups

PR #142 left all mouse events swallowed while any overlay was open.
Most visibly, the commit-info popup (i) supports j/k/g/G keyboard
scroll but ignored the wheel.

Wire tea.MouseMsg through the overlay manager when an overlay is
active:
- commitinfo: wheel adjusts offset by 3; shift+wheel by half viewport
- annotlist:  wheel moves cursor by 1; shift+wheel by half page
- themeselect: wheel moves cursor + live preview; shift+wheel by half page
- help: no scrollable state, wheel is a no-op

Clicks inside overlays remain swallowed (follow-up). --no-mouse still
turns everything off, same flag.

* feat(ui): left-click selection in overlay popups

Extend the overlay mouse routing so left-click inside a popup selects
an item, not just wheel-scrolls it.

- annotlist: click on an item row jumps to that annotation (same as
  Enter) and closes the overlay
- themeselect: click on an entry confirms that theme (same as Enter);
  clicks on filter, blank separator, or border/padding are no-ops
- commitinfo / help: no selectable items, clicks are no-ops

Manager records the popup rectangle during Compose and translates
screen coords to popup-local before dispatch, so each overlay reasons
about its own layout. Clicks outside the popup are swallowed rather
than dismissing, to avoid accidental close.

* fix(ui): address code review findings for overlay mouse support

Bug fixes:
- annotlist/themeselect click handlers now check X coordinate against
  the popup width; clicks on the left/right border or horizontal
  padding are no-ops (previously selected items). Fixes accidental
  theme-persist on mis-clicked chrome.
- themeselect click now updates lastPreviewedName so a subsequent
  keyboard-wheel back to the same entry does not re-emit a preview.

Test improvements:
- Strengthen TestModel_HandleMouse_WheelScrollsCommitInfoOverlay to
  park diffCursor at a non-zero... (continued)

169 of 185 new or added lines in 6 files covered. (91.35%)

8185 of 9137 relevant lines covered (89.58%)

458.5 hits per line