umputun / revdiff / 24821449577
92%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 59
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 89.548% (+0.2%) from 89.327%
24821449577

push

github

web-flow 
feat: leader-based chord keybindings (kitty-style ctrl+w>x) (#143)

* add plan: leader-chord-keybindings

* feat: add chord keybinding parser with ctrl/alt leader validation

Extends parse() to recognize chord bindings like 'ctrl+w>x'. Leader must
be a ctrl+ or alt+ combo; second stage is a single key. Three-stage chords
and empty halves are rejected with a warn. Leader case is normalized
(ctrl+/alt+ lowercased); second-stage case is preserved so ctrl+w>x and
ctrl+w>X stay distinct. Both map and unmap accept chord keys.

* feat: add chord conflict resolution and lazy leader index

Add IsChordLeader/chordPrefixes methods backed by a lazy cache on Keymap,
invalidated on every Bind/Unbind. Add resolveConflicts() at the end of Load()
that drops any standalone binding whose key is also a chord prefix so that
pressing the leader always enters chord-pending state.

* feat: add ResolveChord with layout fallback for chord bindings

* feat: add tests verifying Dump round-trip and KeysFor for chord bindings

Lock in the behavior that chord keys stored as flat strings (ctrl+w>x)
round-trip through Dump/parse and sort alphabetically alongside
single-key bindings via KeysFor and HelpSections.

* feat: extract dispatchAction helper and split pane-nav handlers

Pure refactor preparing for chord dispatch. handleKey's post-Resolve flow
moves into dispatchAction; handleDiffNav and handleTreeNav become thin
wrappers over handleDiffAction and handleTreeAction so keymap-resolved and
chord-resolved paths share the same core.

* feat: add keyState and handleChordSecond for leader-chord dispatch

Introduces keyState sub-struct (chordPending + hint) on Model and the
handleChordSecond method that dispatches resolved chord actions through
dispatchAction, surfaces "Unknown chord" on a miss, and cancels silently
on esc. Wires the chord hint into transientHint() as the lowest-priority
tier so in-flight reload/compact hints still win.

* feat: wire chord-first and chord-second guard... (continued)

8036 of 8974 relevant lines covered (89.55%)

465.69 hits per line

Coverage Regressions

Lines Coverage ∆ File
34
92.92
1.76% app/ui/model.go
13
93.98
0.01% app/ui/annotate.go
11
96.76
1.0% app/keymap/keymap.go
6
95.09
-0.03% app/ui/diffnav.go
6
91.2
0.07% app/ui/search.go
5
98.3
0.01% app/ui/view.go
Jobs
ID Job ID Ran Files Coverage
1 24821449577.1 59
89.55
GitHub Action Run
Source Files on build 24821449577