lsm / neokai / 24789741734

82%

push

github

fix(space): preserve task agent sessions across daemon restart (#1595)

* fix(space): preserve task agent sessions across daemon restart

cleanupAll was treating SIGINT as task completion: it hard-deleted
session DB rows and marked worktrees completed, leaving space_tasks with
dangling task_agent_session_id FKs that rehydrate silently skipped.
After restart the task agent + reviewer disappeared from the dropdown
and the canvas went blank.

- Split cleanupAll into a shutdown path (shutdownTask +
  stopSessionPreserveDb) that interrupts the SDK query but leaves the
  session row and worktree state intact for rehydrate.
- Self-heal dangling task_agent_session_id on rehydrate so any existing
  inconsistent DB state from past bad shutdowns no longer breaks the UI.
- Guard broadcastSessionStateChange against empty sessionId to stop the
  noisy "Session not found" warnings.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* test(space): cover sub-session shutdown and rehydrate self-heal

- shutdownTask: drop redundant listener/callback cleanup that
  stopSessionPreserveDb already performs
- add test: cleanupAll preserves sub-session DB rows while stopping
  in-memory queries
- add tests: rehydrate clears task_agent_session_id when the referenced
  session row is missing or of the wrong type

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

8972 of 12186 branches covered (73.63%)

Branch coverage included in aggregate %.

60 of 60 new or added lines in 2 files covered. (100.0%)

67050 of 75890 relevant lines covered (88.35%)

302.41 hits per line