KarpelesLab / libwallet / 24763430116

25%

Build Type

push

github

Committed by MagicalTux

Commit Message

Web3: cross-chain detection + chain_switch approval

The injector already exposes window.ethereum / window.solana /
window.mpurse unconditionally — but action methods (sign, send,
connect) called against a chain family that doesn't match the
wallet's current network used to either silently mis-route to the
current network's RPC or fail mid-flight with bad accounts.

Detect the family at the top of Web3:request from the method
prefix (eth_/wallet_/personal_/net_/web3_ → evm, solana_ →
solana, mpurse_ → bitcoin). Read-only methods (eth_chainId,
eth_getBalance, etc.) keep the existing relay behaviour;
classified action methods that mismatch the current network
trigger a new chain_switch approval.

The approval request carries:
- requestedFamily, requestedMethod (UI copy)
- currentNetwork (context)
- candidateNetworks (every Network of the requested family —
  user picks the specific chain)
- candidateAccounts (every Account whose key curve fits —
  secp256k1 for evm/bitcoin, ed25519 for solana)

User picks (network, account) in one prompt; libwallet then
SetCurrent's the network AND saves a ConnectedSite for
(host, account). The original method continues against the new
state with the dApp already considered connected to the chosen
account, so subsequent sign / send calls land on the right chain.

Approve API gains a Network field carrying the chosen network id
(account id stays in Accounts[0]). Dart side adds
ChainSwitchRequest with typed accessors for the candidate
network / account lists and a docstring example of how to wire
the picker.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

0 of 125 new or added lines in 3 files covered. (0.0%)

1 existing line in 1 file now uncovered.

2529 of 12106 relevant lines covered (20.89%)

64.85 hits per line