pantsbuild / pants / 24760753851

91%

push

github

Make one of the Pex tests more robust. (#23283)

`test_pex_working_directory[VenvPex]` manually deletes
the venv dir in the PEX_ROOT, in order to test the situation
where pex creation hits the process cache, while venv
seeding misses the pex cache.

However this test was using the real, persistent
named_caches dir, and when pex recreates the venv
it also tries to recreate a short symlink to it, and since
we didn't delete the original symlink (and we can't
because we don't know where it is), pex tries
longer and longer prefixes until it gives up. See:


https://github.com/pex-tool/pex/blob/v2.92.3/pex/pex_bootstrapper.py#L553

So if we run the test enough times we eventually hit the
"universe is broken"case in that comment.

The fix is simply to use a tmp_dir as the named_caches dir,
like several other tests in this file. Then pex will only use up
two of it 33 possible increasing prefixes, and we won't hit
the apocalypse.

3 of 3 new or added lines in 1 file covered. (100.0%)

91685 of 98664 relevant lines covered (92.93%)

4.04 hits per line