lsm / neokai / 24751481267

82%

push

github

fix(space): list_peers shows topology peers; send_message queues for inactive nodes (#1579)

* fix(space): list_peers shows all topology peers; send_message queues for inactive nodes

Bug 1 — list_peers returned empty for not-yet-activated nodes:
- Only queried within-node executions; cross-node peers were invisible until
  their sessions spawned.
- Fix: after resolving within-node peers, query all executions for the run and
  expand permitted topology targets (via ChannelResolver.getPermittedTargets,
  called with both agent slot name and node name). Nodes with no execution
  records are returned as "not_started" peers using agent slots from
  resolveNodeAgents(). Nodes with records are returned with their real status.

Bug 2 — send_message hard-failed for declared-but-inactive targets:
- AgentMessageRouter only loaded executions with agentSessionId, so pending
  targets were invisible and caused "Unknown target" errors.
- Fix: load ALL executions (with and without session) for declared-agent
  detection. When a target has no live session but IS declared (via
  node_executions or channel topology), enqueue via PendingAgentMessageRepository
  instead of failing — mirrors the task-agent-tools queue path. Wire
  pendingMessageRepo + spaceId + taskId into the router via TaskAgentManager.
  Callers receive success:true with a "queued" array in the result.

Updated tests:
- New suite node-agent-tools: list_peers — cross-node peer discovery (4 tests)
- New suite node-agent-tools: send_message — queue-when-inactive (3 tests)
- New suite AgentMessageRouter: queue message for declared-but-inactive target (4 tests)
- Updated 3 pre-existing tests whose "unknown target" assertion changed to
  "no active sessions found" — topology-declared targets are no longer unknown;
  they resolve correctly and only fail at delivery when no session exists.

* test(space): add negative-path coverage for fromNodeName topology resolution

Adds two tests to the AgentMessageRouter ... (continued)

9071 of 12357 branches covered (73.41%)

Branch coverage included in aggregate %.

204 of 204 new or added lines in 3 files covered. (100.0%)

66777 of 75605 relevant lines covered (88.32%)

300.89 hits per line