hyperledger-labs / fabric-smart-client / 24720167728

71%

Build Type

push

github

Committed by web-flow

Commit Message

fix(fabricx): restore arma -> BFT broadcaster alias (#1249)

* fix(fabricx): restore arma -> BFT broadcaster alias

Commit dfdcbba6 (PR #1206 "support for GetConfigTransaction") refactored
the fabricx channel/committer initialization and dropped `NewCommitter`,
which used to register the arma consensus alias:

    os.Broadcasters["arma"] = os.Broadcasters[ordering.BFT]

That alias was not carried over to the new architecture, so v0.9.0+
fabricx can no longer talk to deployments that use fabric-x-orderer /
fabric-x-common, where `ConsensusType="arma"` is the standard (see the
SampleFabricX profile in fabric-x-common/sampleconfig/configtx.yaml and
the encoder ConsensusTypeArma constant).

Symptom in a real fabric-x deployment (FSC v0.10.0 + fabric-x-orderer
v0.0.24 + fabric-x-committer v0.1.9):

    failed to apply config update: failed to update ordering service:
    failed to set consensus type from channel config: no broadcaster
    found for consensus [arma]

The subsequent retries re-invoke membershipService.Update with the same
genesis envelope and trip the sequence-0 config validator, which masks
the root cause:

    failed validating config for channel [arma]: config currently at
    sequence 0, cannot validate config at sequence 0

Fix: translate consensusType "arma" to ordering.BFT inside the fabricx
channel wrapper's Configure adapter. This keeps the alias localized to
fabricx (the fabric generic ordering service is untouched), matches the
intent of the original registration in NewCommitter, and preserves the
"arma IS fabric-x's BFT implementation" semantic that fabric-x-orderer
encodes in its genesis blocks.

Signed-off-by: Stone <stoneshi@sign.global>

Coverage Stats

1 of 3 new or added lines in 1 file covered. (33.33%)

14 existing lines in 4 files now uncovered.

26043 of 39578 relevant lines covered (65.8%)

3034.9 hits per line