pantsbuild / pants / 24699019654

93%

main: 93%

push

github

Fix use of generic target in runtime package dependencies (Cherry-pick of #23248) (#23276)

## What

Fixes the following setup:

```py
# BUILD
pex_binary(name='bin_a', entry_point='main_a.py')
pex_binary(name='bin_b', entry_point='main_b.py')
target(name='all_bins', dependencies=[':bin_a', ':bin_b'])
python_test(name="tests", runtime_package_dependencies=[":all_bins"])
```

Previously the PEX dependencies would not get packaged and materialized
when the tests were run.

## Why

Allows a `target()` alias to be used in `runtime_package_dependencies`
to group packageable targets, rather than having to list each one
individually. This would help simplify a setup I have where I have the
misfortune of having to write a loop to generate a list of targets:

```py
# BUILD
for model in models:
  docker_image(name=model.name)

target(name="models", dependencies=[model.name for model in models])
```

Using the generic target I can isolate this mess to the one relevant
directory and keep the rest of the codebase clear.

## Test plan

- [x] New test added to cover the scenario

## Open questions

- Is this the kind of thing we would add to the release notes? Or is it
a bit niche?
- Is this the most reliable way to implement this? I was surprised to
find that generic target isn't modeled as a `TargetGenerator` would that
be a more robust fix? (sounds like it would be a much more invasive
change)
- I _think_ this issue affects the `archive` target too. Shall I
investigate that in this PR? Or keep it small and investigate
separately?

Co-authored-by: Ryan Loader <talk@ryanloader.me>

17 of 17 new or added lines in 2 files covered. (100.0%)

91686 of 98668 relevant lines covered (92.92%)

4.04 hits per line