ruby-grape / grape / 24695994796

97%

master: 97%

Pull #2690

github

Return frozen EMPTY array from StackableValues on miss

`StackableValues#[]` is the accessor behind `namespace_stackable[key]` —
called multiple times per request (five filter phases, plus ad-hoc
settings lookups). When neither `inherited_values` nor `new_values`
have an entry for the key, the old `return new_value || []` allocated
a fresh empty array on every miss.

Introduce a frozen `EMPTY` singleton and return it in the miss branch.
Saves two short-lived empty-array allocations per request in the
realistic shape (some filters set, some not) and up to five in the
worst case.

One caller (`Endpoint#initialize`) stored `namespace_stackable[:validations]`
directly into `route[:saved_validations]` by reference, and later
`.concat`'d parent validations into it via `inherit_settings`. With the
stackable now able to return a frozen array, that mutation would
`FrozenError`. Dup at capture so the route keeps its own mutable list —
good hygiene regardless of this change.

## Benchmark (1k iterations, 5-key probe per iteration)

Realistic (3 keys populated, 2 absent):
  current: 2.01 M i/s, 80B / 2 objects allocated
  variant: 2.19 M i/s, 0B / 0 objects allocated

Worst case (all 5 absent):
  current: 2.18 M i/s, 200B / 5 objects
  variant: 2.49 M i/s, 0B / 0 objects  (1.14x faster)

No behavior change; all 2,236 specs pass.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

1071 of 1157 branches covered (92.57%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 2 files covered. (100.0%)

3352 of 3406 relevant lines covered (98.41%)

32205.86 hits per line