RobotWebTools / rclnodejs / 24660309015

85%

push

github

Refresh Electron prebuild target and demo apps (#1492)

The `prebuild:electron` script was still pinned to `electron@23.0.0`, an EOL release from Dec 2022 that bundles Node 18.12. Bump it to `electron@34.0.0`, the most recent line whose bundled Node (20.18.1) matches the major version of our `engines.node >= 20.20.2` floor.

The four `electron_demo/*` apps were pinned to `^40.1.0`, which goes EOL on Jun 30, 2026. Bump them to `^41.0.0` (supported through Aug 25, 2026) so demos stay on a maintained, security-patched Electron line ahead of the Lyrical GA window.

N-API ABI stability means binaries built against Electron 34 continue to load cleanly in 41+, so the prebuild-target / demo-target split is intentional and safe.

Fix: #1458

1567 of 1987 branches covered (78.86%)

Branch coverage included in aggregate %.

3183 of 3545 relevant lines covered (89.79%)

448.77 hits per line