hyperledger-labs / fabric-smart-client / 24657977613

71%

Build Type

push

github

Committed by web-flow

Commit Message

fix(storage): migrate SimpleKeyDataStore and KeyValueStore to squirrel (#1235)

* fix(storage): migrate SimpleKeyDataStore and KeyValueStore to squirrel

Migrates SimpleKeyDataStore and KeyValueStore from the deprecated
CondInterpreter query builder to squirrel's PlaceholderFormat,
following the same pattern established for SignerInfoStore and
BindingStore.

Changes:
- common/simplekeydata.go: replace ci CondInterpreter with sq.PlaceholderFormat
- common/unversioned.go: replace ci CondInterpreter with sq.PlaceholderFormat
- sqlite/unversioned.go: pass sq.Question to NewKeyValueStore
- postgres/keyvalue.go: pass sq.Dollar to NewKeyValueStore
- fabric/sql/common: update metadata, endorsetx, envelope constructors
- Update all affected test files to match squirrel SQL format

Part of #1159

Signed-off-by: Siddhi Khandelwal <siddhi.200727@gmail.com>

fix(storage): update fabric sql postgres/sqlite stores to use squirrel PlaceholderFormat

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Siddhi Khandelwal <siddhi.200727@gmail.com>

* style: fix gofmt and goimports issues

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Siddhi Khandelwal <siddhi.200727@gmail.com>

* style: fix import formatting via lint-fmt

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Siddhi Khandelwal <siddhi.200727@gmail.com>

* fix(storage): address review comments - safe query truncation and safe debug logging

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Siddhi Khandelwal <siddhi.200727@gmail.com>

---------

Signed-off-by: Siddhi Khandelwal <siddhi.200727@gmail.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Coverage Stats

76 of 89 new or added lines in 13 files covered. (85.39%)

16 existing lines in 4 files now uncovered.

26058 of 39617 relevant lines covered (65.77%)

2992.48 hits per line