KarpelesLab / libwallet / 24652194098

25%

push

github

Account.Delete: cascade-remove linked Web3 ConnectedSite rows

Up through 0.3.17 deleting an account left a dangling
ConnectedSite row referencing the now-gone Account ID — the
TODO at the original delete site flagged it years ago.

Cascade synchronously, before the account row goes away, so
no orphan ever exists in the DB. Implemented via a minimal
stub struct in wltacct mapping the ConnectedSite table —
keeps wltacct → wltbase free of an import cycle (wltbase
already imports wltacct). Cascade failures are logged but
don't block the account delete: leaving the account behind
because of a stale ConnectedSite would be the worse outcome.

Transactions intentionally NOT cascaded — tx history can
outlive the account that originated it, by design.

New Account.Delete(env) public wrapper around the existing
unexported accountDelete so non-API callers (background
tasks, tests) can drive the same flow.

End-to-end test in wlttest covers: delete the owning account,
its ConnectedSite rows are gone, an unrelated ConnectedSite
is untouched (cascade is correctly scoped, not "delete
everything").

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

0 of 7 new or added lines in 1 file covered. (0.0%)

2494 of 11852 relevant lines covered (21.04%)

65.01 hits per line