kubeovn / kube-ovn / 24645499004

25%

push

github

fix(slr): snapshot subnet/VPC in SwitchLBRuleInfo to avoid VIP leak (#6651)

* fix(slr): snapshot subnet/VPC in SwitchLBRuleInfo to avoid VIP leak

When two SLRs share a health-check VIP and are deleted back-to-back,
handleDelSwitchLBRule can race a concurrent service-delete event: the
service worker's LoadBalancerDeleteVip may remove the LBHC (flipping
ignoreHealthCheck to false due to non-empty IPPortMappings) before the
SLR delete worker runs. servicesLister.Get then returns NotFound,
leaving subnetForVip empty, so both the orphaned-LBHC branch and the
subnet fallback are skipped and the health-check VIP CR is never
deleted. Its IP keeps the subnet's usingIPs > 0, blocking finalizer
removal and stranding the subnet in Terminating.

Capture subnet/VPC from the SLR annotations at enqueue time via
SwitchLBRuleInfo and fall back to them when the service lister no
longer has the service. Also drop the redundant explicit service
deletes from the e2e ip_port_mapping tests — the SLR delete handler
already owns that cleanup, and the extra delete only widens the race.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

* test(slr): cover info.Subnet/VPC fallback in handleDelSwitchLBRule

Adds two unit test cases that exercise the race scenario where the
backing Service has been removed from both the informer cache and the
API before the SLR delete worker runs. The first asserts that VIP
cleanup still succeeds via info.Subnet; the second verifies that
info.VPC keeps the cross-VPC scoping intact so a health check owned
by another VPC is left alone.

Addresses review feedback on #6651.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

---------

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

6 of 8 new or added lines in 1 file covered. (75.0%)

13974 of 56515 relevant lines covered (24.73%)

0.29 hits per line