ArduPilot / MethodicConfigurator / 24641248417

96%

push

github

fix(connection): release flight controller on connection window close

ConnectionSelectionWindow.close_and_quit() called sys_exit(0) without
first calling flight_controller.disconnect(). When the user closed the
window via the window manager (X button, Cmd-Q, Alt-F4) instead of
using one of the in-window buttons, the MAVLink link and the
underlying serial port were left open until the OS reclaimed the file
descriptor.

On Windows this left the COM port locked long enough that relaunching
AMC, or running mavproxy / Mission Planner against the same port, hit
a PermissionError on open. skip_fc_connection() on the same class
already calls flight_controller.disconnect() before destroying the
window, so close_and_quit was the inconsistent path.

Store the flight_controller reference on the window in __init__ and
call disconnect() from close_and_quit, mirroring the skip path.

Add a regression test that patches sys_exit and asserts the mock
flight controller's disconnect() is called when close_and_quit fires,
sibling to the existing test_skip_fc_connection that checks the same
invariant on the other exit path.

Fixes #1525

Signed-off-by: Yash Goel <yashvardhan664@gmail.com>

1766 of 1827 branches covered (96.66%)

11508 of 12218 relevant lines covered (94.19%)

3.73 hits per line