ArduPilot / MethodicConfigurator / 24637765595

96%

push

github

fix(connection): prevent IndexError on malformed ChibiOS banner line

_extract_chibios_version_from_banner crashed with IndexError when a
banner line starting with "ChibiOS:" did not contain a space followed
by a version hash (for example a truncated "ChibiOS:" line, or
"ChibiOS:hash" without the expected space separator).

msg.split(" ")[1] unconditionally indexed the second element of the
split, which does not exist when the separator is absent. The
IndexError propagated out of the banner-parsing loop during flight
controller connection setup and aborted the whole connection attempt.

Use split(" ", 1) and guard the length before indexing, falling back
to an empty version string. The surrounding code already handles an
empty os_custom_version correctly (it logs a version mismatch warning
against info.os_custom_version when the two differ).

Add two unit tests covering the malformed banner cases that previously
raised IndexError.

Signed-off-by: Yash Goel <yashvardhan664@gmail.com>

1762 of 1823 branches covered (96.65%)

11489 of 12199 relevant lines covered (94.18%)

3.74 hits per line