ruby-grape / grape / 24629950730

97%

master: 97%

Build Type

Pull #2686

github

Committed by ericproulx

Commit Message

Precompute middleware content-type caches on the parent instance

Grape::Middleware::Base#call does dup.call!(env) per request, so the
+||=+ memoization on content_types / mime_types / content_types_indifferent_access
lived on the per-request dup — it was computed fresh every request.

This change:

- Adds a protected +precompute_content_types!+ helper on +Middleware::Base+
  that populates the three ivars on the parent instance at initialization
  time. Per-request dups then inherit the cached values via +dup+'s ivar
  copy instead of recomputing +with_indifferent_access+ (~1 µs each).
- Has +Middleware::Error+, +Middleware::Formatter+, and
  +Middleware::Versioner::Base+ call it from their +initialize+ (after
  +super+). Versioner::Base additionally warms +available_media_types+.
- Short-circuits +Middleware::Base#merge_headers+ when no headers were
  set, avoiding both the lazy +Grape::Util::Header.new+ allocation and
  an empty +merge!+ against the response.

No behavior change. Only middlewares that actually read content_types
opt into the warmup — plain +Middleware::Base+ subclasses still pay
nothing.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #2686: Precompute middleware content-type caches on the parent instance

Coverage Stats

1070 of 1158 branches covered (92.4%)

Branch coverage included in aggregate %.

17 of 18 new or added lines in 4 files covered. (94.44%)

7 existing lines in 3 files now uncovered.

3360 of 3414 relevant lines covered (98.42%)

33337.07 hits per line