KarpelesLab / goro / 24621429745

13%

push

github

Move extension-specific Global state behind a generic StateKey API

core/random and core/phpv were growing extension-aware surface area:
random.State had a gmp-specific .Gmp field and GmpSeed method, and
phpv exposed a StrtokState type + Strtok() accessor on GlobalContext
that only ext/standard touched. Core shouldn't know about either.

Replace both with a single generic mechanism:

  - phpv.StateKey is an opaque, pointer-identity-compared handle an
    extension allocates once at package init via phpv.NewStateKey("name").
  - GlobalContext gains State(key) / SetState(key, value), backed by
    a lazily-allocated map[*StateKey]any on *Global.
  - Extensions own the typed wrapper: ext/gmp/misc.go declares
    gmpRandKey and casts the stored value back to *mathrand.Rand;
    ext/standard/strings.go does the same for its strtokState struct.

Mirrors context.WithValue but scoped to the request-lifetime Global,
which is where these values actually belong.

Removed:
  - random.State.Gmp and GmpSeed
  - phpv.StrtokState
  - GlobalContext.Strtok() and the strtok field on *Global

Build, vet, CGO_ENABLED=0 build, and locale+crypt unit tests are all clean.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

3 of 33 new or added lines in 4 files covered. (9.09%)

2188 of 111907 relevant lines covered (1.96%)

70.39 hits per line