KarpelesLab / goro / 24621373581

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

ext/gmp: give gmp_random_* its own per-request MT19937 state

Previously ext/gmp/misc.go kept the seeded RNG in a package-level
gmpRandSource, which had two problems: (1) a data race when two
goroutines called gmp_random_bits concurrently, and (2) the seed
leaked across script executions — an FPM/httpd request calling
gmp_random_seed() would affect the next request's output.

MT19937 instances are independent; mt19937.New(seed) returns a
fresh *Source each call. Add a Gmp field to core/random.State
alongside Mt, plus a GmpSeed(int64) method that mirrors MtSeed.
Then point gmp_random_* at ctx.Global().Random().Gmp so the state
follows the same per-request lifecycle as mt_rand.

Same fix pattern as the strtok-state move — package globals that
hold request-scoped PHP state get moved onto the Global context.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

0 of 9 new or added lines in 2 files covered. (0.0%)

1 existing line in 1 file now uncovered.

2185 of 111884 relevant lines covered (1.95%)

70.4 hits per line