Freegle / Iznik / 4987

70%

Build Type

push

circleci

Committed by web-flow

Commit Message

fix(sentry): suppress Freestar ftUtils.js null-document errors (#206)

* fix(sentry): suppress Freestar ftUtils.js null-document errors

Freestar's third-party ad JS (ftUtils.js) calls
(this.isPlacementXdom?t:t.parent).document inside getPlacementPosition.
When t.parent is null (typically a cross-origin iframe context), this
throws "Cannot read properties of null (reading 'document')".

Sentry issue NUXT3-CES (id 6579683231): ~11,409 events from 956 users,
last seen 2026-04-18. We can't edit the vendored Freestar JS, so silence
the noise on our side.

- composables/useSuppressException.js: drop errors whose stack contains
  ftUtils.js or getPlacementPosition (Freestar signature; conservative
  enough not to mask real bugs in our own code).
- plugins/sentry.client.ts: add 'getPlacementPosition' to ignoreErrors
  as a belt-and-braces second filter.
- tests/unit/composables/useSuppressException.spec.js: add coverage for
  both Freestar matches and a negative control showing an unrelated
  null-document TypeError still passes through.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(phpunit-ci): surface testenv.php failures and clear stale DB-down markers

CircleCI build 4933 on this PR (unrelated Sentry/Freestar change) showed
5 errors + 34 failures because testenv.php failed to connect to the
per-worker databases during setup. The bash runner printed "Test
environment setup complete." unconditionally and ran the suite on
unfixtured DBs, so the FreeglePlayground group was missing and all
dependent assertions collapsed into phantom failures that looked like
product bugs.

Two real defects contributed:

1. include/LoggedPDO.php::doConnect() caches a "host down" marker at
   /tmp/iznik.dbstatus.<host>:<port>.down on any connect error and then
   short-circuits every retry within 60s (`$checkit = FALSE`). Because
   allDownRetries=30 with 1s sleeps, the loop *never* re-tries a real
   connection before throwing — producing the "Sleep for all D... (continued)

Coverage Stats

13302 of 20339 branches covered (65.4%)

Branch coverage included in aggregate %.

12 of 12 new or added lines in 1 file covered. (100.0%)

38 existing lines in 6 files now uncovered.

95757 of 132180 relevant lines covered (72.44%)

21.59 hits per line