MushroomObserver / mushroom-observer / 24595854660

96%

main: 96%

Build Type

Pull #4143

github

Committed by JoeCohen

Commit Message

Add intermediate taxonomic ranks to Name enum

Add Series, Subtribe, Subfamily, Suborder, Subclass, and Subphylum to
the `Name` rank enum with appropriate integer values preserving sort
order between existing ranks.

- Derive `ranks_above_genus` dynamically from the enum (all ranks with
  value > Genus) so the list stays correct as ranks are added
- Add en.txt translation keys (singular, lowercase, and plural variants)
  for all 6 new ranks; regenerate all locale YMLs
- Add one fixture per new above-genus rank forming a classification chain
  against existing fixtures (Basidiomycota → Agaricomycotina,
  Basidiomycetes → Agaricomycetidae, Agaricales → Agaricineae,
  Agaricaceae → Agaricioideae, Agaricioideae → Agaricini); add
  Amanita ser. Vaginatae fixture for Series rank
- Extend `test_scope_subtaxa_of` with assertions for each new
  above-genus rank in `immediate_subtaxa_of`
- Fix `test_next_and_prev` to order by `sort_name` (matching the
  controller) rather than `text_name, author`
- Fix `test_name_search_rank` to dynamically compute the lowest
  above-genus rank for the `rank:X-domain` search term

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Pull Request Pull Request #4143: Fix fill in missing ranks

Coverage Stats

13 of 15 new or added lines in 2 files covered. (86.67%)

1 existing line in 1 file now uncovered.

37154 of 38590 relevant lines covered (96.28%)

663.98 hits per line