Freegle / Iznik / 4788

70%

Build Type

push

circleci

Committed by web-flow

Commit Message

fix(ModLogsModal): dedupe logs on push to prevent duplicates (#196)

Reproduces Discourse 9518.181 — @Neville_Reid reported the ModLogsModal
showed the same four-row block repeated three times on the Pending
Message page.

Root cause is client-side. The server query (SELECT logs.* FROM logs
WHERE ... ORDER BY logs.id DESC LIMIT ?) has no amplifying JOIN and
pagination is exclusive (logs.id < ?) so it cannot return the same
row twice in one call. But multiple ModLogsModal / ModPostingHistory
instances on the same page share a single global Pinia store, and
rapid re-opens can run fetchChunk concurrently. Both in-flight fetches
see this.context === null, both request page 1, both push identical
rows into the shared list.

Dedupe by id on push so repeated or concurrent fetches of overlapping
pages (including a later fetch that straddles the previous context
boundary) cannot produce visible duplicates.

Two Vitest tests cover the concurrent and sequential-overlap cases.
Full suite 11794/11794 passes.

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

13286 of 20292 branches covered (65.47%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

60 existing lines in 10 files now uncovered.

94680 of 131342 relevant lines covered (72.09%)

19.97 hits per line