agama-project / agama / 24568491419

77%

master: 81%

push

github

Support to configure the bootloader type to use (#3350)

## Problem

Quite some logic has been introduced lately in yast2-bootloader and in
yast2-storage-ng to decide which bootloader to install in every case
(Grub2, systemd-boot, grub2-bls, etc.).

That logic is duplicated in both YaST components but, unfortunately, it
is not identical.

Moreover, that logic is based on the system architecture and in some
YaST-specific configurations like
`Yast::ProductFeatures.preferred_bootloader`. Although initially a
`YAST_NO_BLS_BOOT` environment variable was introduced as a mechanism to
avoid the YaST changes to affect Agama, that is not longer working after
several changes in that area.

## Solution

This introduces a reasonable mechanism to select the bootloader type to
use in Agama.

The setting is handled internally in the Agama configuration but not
exposed in JSON yet. For now, products can define the default bootloader
for EFI environments.

Both yast2-bootloader and yast2-storage-ng will now honor the setting,
which value is now handled with a single centralized mechanism.

## Notes

This is a pull request against a feature branch. It introduces new
classes like `Y2Storage::Proposal::BootPlanner` or
`Agama::Storage::BootloaderType` that would need to be re-evaluated.
Before merging the feature branch into master, it will maybe make sense
to consolidate some of those with yast2-storage-ng.

177 of 195 new or added lines in 11 files covered. (90.77%)

8214 of 9269 relevant lines covered (88.62%)

109.89 hits per line