KarpelesLab / libwallet / 24554724114

25%

push

github

Swap: detect required approvals + add Swap:buildApproval with tight default

1inch quotes now read the router's current allowance via
eth_call on ERC-20 allowance() and populate SwapQuote.
requiresApproval / approvalSpender / currentAllowance /
neededAllowance. Native ETH inputs skip the check.

New Swap:buildApproval endpoint returns a validated
Transaction (Type=evm, approve(spender, amount) calldata) the
caller feeds into Transaction:signAndSend. The default
approval amount is exactly the quote's amountIn — a
compromised router can only drain what the user already
agreed to. Opt into 'max' for classic unlimited approve or a
custom decimal for a batch cap; in both cases the app should
surface the widened blast radius to the user.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

41 of 166 new or added lines in 3 files covered. (24.7%)

2473 of 11705 relevant lines covered (21.13%)

68.41 hits per line