rpgmem / ffcertificate / 24543468876

70%

push

github

Claude/review repo improvements w p bhb (#32)

* test: add 45 tests covering Geofence validation + Loader initialization

New test files:
- GeofenceDatetimeValidationTest (12 tests): daily + span mode datetime
  validation, all branch paths including edge cases
- GeofenceGeolocationTest (17 tests): parse_areas, validate_geolocation
  with IP fallback scenarios, has_form_expired_by_days
- GeofenceFrontendConfigTest (10 tests): get_form_config boolean casting,
  get_frontend_config with admin bypass / partial bypass / regular user
- LoaderTest (6 tests): constructor hook registration, frontend asset
  registration and localization

Closes the remaining coverage gaps in security-critical geofence code
and the main plugin loader.

https://claude.ai/code/session_013mTv5ethMq15faTc8FKta9

* fix(geofence): frontend config flags always false due to type mismatch

get_form_config() casts boolean fields to PHP bool (true/false), but
get_frontend_config() compared them with '1' === $config['...'] which
is always false ('1' === true → false in PHP strict comparison).

This caused the JS frontend to never enforce datetime or geolocation
restrictions — forms were always shown regardless of configured
restrictions. The backend validation in can_access_form() was
unaffected (uses truthiness check).

Fix: compare the already-cast boolean values directly instead of
against the string '1'.

https://claude.ai/code/session_013mTv5ethMq15faTc8FKta9

* fix(admin): correct submission link filter + add CSV download column

1. Fix submission count link: use filter_form_id instead of form_id
   so clicking the count actually filters the submissions list.

2. Add "CSV Downloads" column to the forms list table showing the
   public download count for forms with CSV download enabled.
   Displays count/limit when a quota is set, or just the count
   otherwise. Shows dash when CSV download is not enabled.

https://claude.ai/code/session_013mTv5ethMq15faTc8FKta9

* feat(geofence): ad... (continued)

116 of 238 new or added lines in 5 files covered. (48.74%)

16890 of 28803 relevant lines covered (58.64%)

3.4 hits per line