rpgmem / ffcertificate / 24542627676

70%

push

github

Claude/ci cleanup composite action (#31)

* ci: extract composite action for PHP+Composer setup, remove CodeQL

DRY out repeated setup-php / composer-cache / composer-install blocks
across ci.yml (3 jobs) and phpcs.yml (1 job) into a reusable composite
action at .github/actions/setup-composer.

Remove the CodeQL workflow — it only scanned JavaScript, which this
plugin has minimal custom code for. PHPStan already provides stronger
static analysis for the PHP codebase.

https://claude.ai/code/session_013mTv5ethMq15faTc8FKta9

* test: add 45 tests covering Geofence validation + Loader initialization

New test files:
- GeofenceDatetimeValidationTest (12 tests): daily + span mode datetime
  validation, all branch paths including edge cases
- GeofenceGeolocationTest (17 tests): parse_areas, validate_geolocation
  with IP fallback scenarios, has_form_expired_by_days
- GeofenceFrontendConfigTest (10 tests): get_form_config boolean casting,
  get_frontend_config with admin bypass / partial bypass / regular user
- LoaderTest (6 tests): constructor hook registration, frontend asset
  registration and localization

Closes the remaining coverage gaps in security-critical geofence code
and the main plugin loader.

https://claude.ai/code/session_013mTv5ethMq15faTc8FKta9

* fix(geofence): frontend config flags always false due to type mismatch

get_form_config() casts boolean fields to PHP bool (true/false), but
get_frontend_config() compared them with '1' === $config['...'] which
is always false ('1' === true → false in PHP strict comparison).

This caused the JS frontend to never enforce datetime or geolocation
restrictions — forms were always shown regardless of configured
restrictions. The backend validation in can_access_form() was
unaffected (uses truthiness check).

Fix: compare the already-cast boolean values directly instead of
against the string '1'.

https://claude.ai/code/session_013mTv5ethMq15faTc8FKta9

* fix(admin): correct submission link filter + add... (continued)

8 of 26 new or added lines in 2 files covered. (30.77%)

16787 of 28597 relevant lines covered (58.7%)

3.4 hits per line