Alan-Jowett / sonde / 24532469700

82%

push

github

fix(sonde-pair): align specs and tests with implementation (#752)

* fix(protocol): align spec and tests with implementation (#744)

Address 6 maintenance audit findings (1 false positive):

fix-impl — Add missing tests:
- F-005: Add 	est_p017 (frame exactly MIN_FRAME_SIZE = 27 bytes)
- F-005: T-P019d confirmed as false positive — test already exists
  as ead_nonce_construction
- F-021: Add 	est_p123..	est_p126 for MAX_APP_DATA_BLOB_SIZE (218)
  and MAX_COMMAND_BLOB_SIZE (193) boundary conditions

fix-spec — Update design docs to match implementation:
- F-003: Document PeerRequest/PeerAck codec bypass in §6.3; remove
  phantom enum variants from §6.1/§6.2
- F-022: Add InvalidParameter(String) to §8 error enumeration
- F-045: Update §5.3 DecodedFrame to zero-copy DecodedFrame<'\''a>
  with &'\''a [u8]; update §5.4 open_frame signature
- F-048: Document MAX_STRING_FIELD_LEN (32 bytes) in §6.5

Closes #744

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* fix(sonde-pair): align specs and tests with implementation (#746)

Maintenance audit identified 6 findings in sonde-pair. This commit
addresses all of them:

F-001 (Critical): Fix stale NODE_PROVISION wire format in PT-0407.
  Remove phone_key_hint[2] and phone_psk[32] from the body layout —
  phone credentials are inside the pre-built PEER_REQUEST frame, not
  separate fields. Update ncrypted_payload description to match
  protocol spec §6.6. Also fix stale PT-0406 overhead description and
  security.md NODE_PROVISION field list.

F-013 (Medium): Add explicit T-PT-311 wire format assertions to
  provision_node_happy_path — byte-level checks for
ode_key_hint,

ode_psk, f_channel, payload_len, and body length.

F-035 (Medium): Rewrite design §5.1 BleTransport trait to match
  implementation: Pin<Box<dyn Future>> instead of sync_trait,
  &mut self, &[u8; 6] addresses, explicit service/characteristic
  UUIDs, pairing_method()... (continued)

35 of 36 new or added lines in 2 files covered. (97.22%)

24302 of 30050 relevant lines covered (80.87%)

204.87 hits per line