Alan-Jowett / sonde / 24531244089

82%

Build Type

push

github

Committed by web-flow

Commit Message

fix(gateway): add test coverage for GW-0405 AC5 and GW-0808 T-0815a-e (#751)

* fix(gateway): add test coverage for GW-0405 AC5 and GW-0808 T-0815a-e (#745)

Address maintenance audit findings F-025 and F-028:

F-025 — GW-0405 initial map data edge cases:
- Add `extract_global_section_data_maps_no_initial_data` test confirming
  that explicit `.maps` sections are excluded from initial data extraction
  (AC5). Builds an ELF with both `.maps` and `.rodata`, asserts only
  `.rodata` produces initial data.
- Add AC6 doc-comment to existing `extract_global_section_data_rodata_prefix`
  test confirming prefix matching for `.rodata.str1.1`.

F-028 — GW-0808 channel persistence lifecycle:
- Extract `resolve_espnow_channel()` from the gateway binary into
  `engine.rs` as a testable library function. The binary now calls this
  function instead of inlining the seed/load logic.
- Add T-0815a: `SetModemChannel(7)` persists `espnow_channel = "7"` in DB.
- Add T-0815b: modem reconnect uses `resolve_espnow_channel()` to restore
  persisted channel 7 instead of CLI default.
- Add T-0815c: BLE `REGISTER_PHONE` response carries `rf_channel = 7` from
  DB-resolved channel.
- Add T-0815d: fresh DB + CLI `--channel 3` seeds DB with "3" via
  `resolve_espnow_channel()`.
- Add T-0815e: pre-populated DB with "7" overrides CLI `--channel 3` via
  `resolve_espnow_channel()`.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* style: apply cargo fmt

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* fix: validate channel range in resolve_espnow_channel

Reject cli_channel and persisted values outside 1..=14 to prevent
invalid channels from being seeded into the database or returned
to the caller.

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

---------

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Copilot... (continued)

Coverage Stats

102 of 111 new or added lines in 3 files covered. (91.89%)

1 existing line in 1 file now uncovered.

24267 of 30014 relevant lines covered (80.85%)

205.11 hits per line