kobotoolbox / kpi / 24519695490

82%

master: 76%

push

github

fix(map): allow multiple queries on map display DEV-1847 (#6924)

### 📣 Summary
Fixes a bug where the frontend was only displaying one page of results
(1000) regardless of the limit placed

### 💭 Notes
Created a functional component wrapper to avoid a full functional
component refactor of the `map/index.tsx` component. A bit of
refactoring was needed to allow this to function properly, 🤖 (and
trimmed by me) summary below:

Key Updates:
- New `FormMapWrapper` component wraps the existing `FormMap` with React
Query-based data fetching
- `FormMap` converted to presentational component receiving data via
props (`allData`, `isLoading`,`totalCount`) instead of fetching
internally
  - Query limit changes:
    - Slider now respects actual data bounds
  - Loading UX: Shows "Fetching points..." overlay during data loads
- Old `requestData()` → now `createDataQuery()` (sets query params,
doesn't fetch)
- Map rebuild logic split into `createDataQuery()` +
`rebuildMapLayers()`


### 👀 Preview steps
⚠️ **`mockobo` is a must for previewing these changes**

-- Setup --

1. ℹ️ Have an account and a project
2. Create a form with a select one question, any other question, 2
geopoint quetions
3. Use `mockobo` to generate ~7000 submissions (not a hard number, just
enough so you can play around with the query slider)

-- On main --

1. Open the map
2. Click on the map settings icon
3. If your submission count is > 1000, you should see the query slider
4. Adjust the slider to any amount > 1000
5. 🔴 notice that the number of submission don't chance (it may be easier
to see the number by clicking on "Disaggregate by survey response" and
selecting a question)
6. Select the highest value on the slider (30,000) before moving to the
PR branch
7. Navigate off the map
8. Notice the `queryLimit` is set to `30000` in the `map_styles`
attribute in the asset json
9. Switch the branch to PR branch

-- On PR --
Below can also be described as "map works as expected", but I outlined
as muc... (continued)

7828 of 12040 branches covered (65.02%)

29773 of 36207 relevant lines covered (82.23%)

5.79 hits per line