KarpelesLab / libwallet / 24504778004

25%

Build Type

push

github

Committed by MagicalTux

Commit Message

Solana ed25519 self-heal: cover every sign path + visibility log

0.3.10 put the pre-flight repair in tx.signAndSendSolana only. A
tester reports sends still fail, which means they're hitting one of
the OTHER Solana sign paths where acct.Pubkey stays stale:

 - Account:signAndSendTransaction / Account:signTransaction
   (shared helper signSolanaTransaction in sign_api.go)
 - Account:signMessage with Mode="solana"
 - Web3 solana_sign_message / solana_sign_transaction /
   solana_sign_send_transaction (wltbase/request.go)

Extract the repair into wltacct.EnsureEd25519PubkeyOnAccount which:
 - runs wltwallet.EnsureEd25519Pubkey on the parent wallet (as
   before)
 - when a repair happens, patches a.Pubkey + re-derives a.Address
   for the current network, AND persists the Account row
   SYNCHRONOUSLY instead of waiting for the async wallet:
   pubkey_repaired handler — so the dApp's next FindAccount returns
   the corrected row in the same request lifecycle
 - emits a log line with old/new pubkey + address so testers can
   grep for "ed25519-repair:" and confirm the self-heal fired

Apply the helper at the top of every Solana-capable sign entry
point. For pre-built-tx paths (dApp/Web3 sends a base64 tx that
already encodes the wrong fee-payer) the CURRENT attempt will still
be rejected by Solana — but the dApp's next window.solana.publicKey
read returns the correct address, so the retry succeeds without the
user knowing.

tx.signAndSendSolana builds the tx itself AFTER the repair, so its
first attempt still succeeds (behaviour unchanged from 0.3.10).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Coverage Stats

0 of 46 new or added lines in 4 files covered. (0.0%)

5 existing lines in 2 files now uncovered.

2119 of 10063 relevant lines covered (21.06%)

2.53 hits per line