KarpelesLab / libwallet / 24502820905

25%

push

github

Solana ed25519 pubkey self-heal: fix type assertion + pre-flight repair

The self-heal I added in 2c8b25d had two bugs that kept existing
broken wallets failing:

1. `aopt.Context.(wltintf.Env)` never matched. aopt.Context is a
   plain context.Context (usually *apirouter.Context); Env is
   attached as an object on it. Fixed to use wltintf.GetEnv(ctx) so
   the save + wallet:pubkey_repaired emit actually run.

2. Repair fired mid-TSS, after the tx had already been built from
   the stale acct.Pubkey. Even when a retry would work (fresh acct
   load from DB), the first send still failed. Added a pre-flight
   step in wlttx.signAndSendSolana that:
   - Fetches the wallet,
   - Calls new wltwallet.EnsureEd25519Pubkey (decrypts one key to
     extract the canonical compressed-Y pubkey, compares, patches
     wallet + emits wallet:pubkey_repaired if needed),
   - Patches acct.Pubkey in memory for the current call so the tx
     is built with the correct fee-payer.
   First send succeeds on upgraded wallets; no retry needed.

EnsureEd25519Pubkey is exported so any future Solana signing flow
(direct sign_api, WalletConnect handler, etc.) can call it for the
same free repair.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

0 of 52 new or added lines in 2 files covered. (0.0%)

2119 of 10023 relevant lines covered (21.14%)

2.55 hits per line