bluesky / hklpy2 / 24494368876

100%

push

github

SolverBase should define a UB setter (#351)

* fix #348 add U and UB getter/setter pair to SolverBase

Core.update_solver() and Core.sample.setter both assign solver.U and
solver.UB to restore orientation state, wrapped in try/except
AttributeError. SolverBase had no U property at all and only a UB
getter (returning a hardcoded IDENTITY_MATRIX_3X3), so non-hkl_soleil
solvers silently discarded the UB on every forward()/inverse() call.

Add U and UB as a matched getter/setter pair on SolverBase. Both are
initialised to IDENTITY_MATRIX_3X3 in __init__ and stored in _U/_UB.
This makes SolverBase a proper calculator interface: Core can push
orientation state in and expect to read it back unchanged. HklSolver's
existing overrides (which push into libhkl internals) are unchanged.

Agent: OpenCode (claudesonnet46)

* test #339 fix Plan.__del__ crash in test_zone_deprecated_shims

The shim tests called func() with no args, which instantiated a bluesky
Plan generator that was never iterated. The bluesky Plan.__del__ then
raised AttributeError('_stack'), causing pytest to exit with code 2
(PytestUnraisableExceptionWarning treated as error) even though all
tests passed.

Fix: patch the underlying plan symbol in hklpy2.plans before calling
the shim, so the shim emits only the DeprecationWarning without
delegating to the @plan-decorated function.

Agent: OpenCode (claudesonnet46)

* refactor #348 remove dead try/except AttributeError for solver.U/UB in ops.py

Now that SolverBase defines U and UB as a full getter/setter pair,
the AttributeError guards in Core.sample.setter and Core.update_solver()
are unreachable dead code. Remove them.

This also tightens the hot forward()/inverse() call path (one fewer
try/except per call) — consistent with the goal of treating SolverBase
as a clean calculator interface.

Agent: OpenCode (claudesonnet46)

16 of 16 new or added lines in 2 files covered. (100.0%)

3182 of 3182 relevant lines covered (100.0%)

4.99 hits per line