Alan-Jowett / sonde / 24491787500

82%

push

github

fix(node): async queue integration tests, redundant clear, and RTC layout docs (#737)

* fix(node): async queue tests, redundant clear, and RTC layout docs

F-002: Add 2 integration tests in wake_cycle.rs:
  - t_n622: verify send_async blob piggybacked on WAKE (CBOR key 10)
  - t_n626: verify queue cleared after drain (multiple blobs via APP_DATA)

F-003: Remove redundant async_queue.clear() after WAKE piggybacking.
  The drain() call later already clears the queue.

F-004: Document async queue RTC layout in node-design.md section 8.6:
  magic sentinel, slot structure, corruption recovery, commit pattern.

F-006: Add test_helper_send_async_ephemeral in bpf_dispatch.rs
  verifying ephemeral programs can call send_async (ND-0602 AC6).

Closes #715

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* fix(node): restore piggyback clear and fix RTC layout docs

- Restore async_queue.clear() after WAKE piggybacking — it is NOT
  redundant: single_for_piggyback() only reads without removing, so
  without clear() the blob would be resent as APP_DATA by drain()
- Fix RTC layout sizes: MAX_APP_DATA_BLOB_SIZE is 218 (not 223),
  slot size is 224 (repr(C) padding), total 2,248 bytes
- Add assertion in t_n622 that piggybacked blob is not resent as
  APP_DATA (only 1 outbound frame expected)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* fix(node): fix stale test comment for piggyback clear path

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* style(node): fix rustfmt in piggyback assertion

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* docs(node): fix fence ordering and slot notation in RTC layout

- Change "volatile write + fence" to "fence + volatile w... (continued)

114 of 116 new or added lines in 2 files covered. (98.28%)

23991 of 29808 relevant lines covered (80.49%)

183.25 hits per line