Alan-Jowett / sonde / 24487935944

82%

push

github

fix(pair): extract timeout constants and add pin config CBOR test (#731)

* fix(pair): extract timeout constants and add pin config CBOR test

F-024: Extract hardcoded timeout values to named constants with
requirement traceability:
- `PHONE_REGISTERED_TIMEOUT_MS` = 30_000 (PT-1002)
- `NODE_ACK_TIMEOUT_MS` = 5_000 (PT-1002)
- `DIAG_RELAY_TIMEOUT_MS` = 10_000 (PT-1303)

F-017: Add `pin_config_cbor_deterministic` test verifying PT-1214 AC2:
- CBOR map uses integer keys in ascending order (1, 2)
- Exact byte output matches expected encoding (A2 01 05 02 06)

F-015: Already resolved — HMAC references in ble-pairing-protocol.md
are already marked RETIRED.
F-016: Already resolved — `resolve_pin_config` asymmetric rejection
tests already exist.
F-025: Deferred — PT-0601 (Should priority) requires UI/store
integration beyond this PR's scope.

Closes #697

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* fix(pair): use structured tracing for timeout values

Log timeout_ms as a tracing field instead of hardcoding the value
in the trace message string, so logs stay accurate if the constant
changes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* fix(pair): use u64::try_from for CBOR integer key conversion

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

---------

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

35 of 36 new or added lines in 2 files covered. (97.22%)

23854 of 29690 relevant lines covered (80.34%)

183.87 hits per line