blevesearch / bleve / 24472271018

52%

Build Type

push

github

Committed by web-flow

Commit Message

Fix `null` issue when parsing search request attributes (#2312)

- We allow parsing a few attributes of the search request as
`json.RawMessage` like
    - `KNN Params`
    - `KNN Filter`
    - `PresearchData`
- It is possible for the JSON body to contain the keyword `null` for
these attributes, especially after a marshal-unmarshal cycle.
- This `null` value is passed on downstream, causing every check for
`len(attribute) > 0` to succeed and take the path for which the
attribute is valid even if the attribute is actually `nil`.
- Fix this issue by adding a custom type that parses `null` specially
and sets the attribute to `nil` when required.

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Coverage Stats

15 of 27 new or added lines in 2 files covered. (55.56%)

6 existing lines in 1 file now uncovered.

19425 of 37609 relevant lines covered (51.65%)

0.58 hits per line