agama-project / agama / 24394789773

78%

master: 83%

Build Type

Pull #3367

github

Committed by dgdavid

Commit Message

fix(web): deduplicate addresses when editing connections

Fixes a bug where IP addresses appeared twice when editing a connection                                          that was previously saved with addresses.

The issue occurred because extendCollection merges config and system
connections with mergeArrays: true, concatenating addresses from both
sources. After saving a connection, the same addresses exist in both
config (user's explicit settings) and system (NetworkManager's active
state), causing duplication when editing.

Thus, this commit deduplicate addresses, nameservers, and DNS search
domains in connectionToFormValues before populating the form.
Add regression test to verify addresses are not duplicated when config
and system have the same address.

Pull Request Pull Request #3367: refactor(web): network connection form UX (bonus part)

Coverage Stats

3558 of 5536 branches covered (64.27%)

Branch coverage included in aggregate %.

92 of 97 new or added lines in 8 files covered. (94.85%)

10 existing lines in 6 files now uncovered.

21301 of 26349 relevant lines covered (80.84%)

90.14 hits per line