KarpelesLab / libwallet / 24394463890

25%

Build Type

push

github

Committed by MagicalTux

Commit Message

fix: handle BtcAmount serialization + guard NFT type assertions

Three lurking bugs found by audit after the modchain_assets balance fix:

1. wlttx/bitcoin.go: bitcoinTxo.Amt and bitcoinTxoResp.Balance were
   declared as int64 but modchain serializes them via outscript.BtcAmount
   (decimal string format like "0.00000001"). Same root cause as the
   modchain_assets bug. Switch to outscript.BtcAmount type — its
   UnmarshalJSON handles both decimal and integer forms.

2. wltnet/network.go: refactored bitcoinBalance to also use BtcAmount
   directly instead of the json.Number + big.Float fallback. Cleaner.

3. wltnet/nft.go: unsafe type assertions on modchain_assets response
   (asset["asset"].(string), asset["address"].(string), etc) would
   panic if any field was missing or the wrong type. Replace with
   comma-ok form and skip malformed entries.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Coverage Stats

0 of 23 new or added lines in 3 files covered. (0.0%)

1 existing line in 1 file now uncovered.

1878 of 7322 relevant lines covered (25.65%)

3.22 hits per line