elixir-mint / mint / 5d8c622fd5e76ca8cb415a8855a345f2ece86842-PR-481

88%

main: 88%

Build Type

Pull #481

github

Committed by ericmj

Commit Message

Track advertised receive window synchronously in initiate/5

Streams opened before the server's SETTINGS ACK arrived were reading
their initial receive window from `conn.client_settings`, which still
held library defaults at that point. If the user advertised a stream
window smaller than the default (e.g. `initial_window_size: 65_535`),
the stream struct tracked the 4 MB default locally while the server
respected the 65_535 we sent in SETTINGS. The client's remaining
window never dropped to the refill threshold, stream-level
WINDOW_UPDATE frames never fired, and the connection stalled once the
server exhausted its per-stream send window.

Mirror the advertised `client_settings_params` into
`conn.client_settings` during `initiate/5` — the sender already knows
what it committed to and doesn't need to wait for the ACK to act on
it. Add a regression test that opens a stream before the ACK round
trip and asserts the stream struct reflects the advertised value.

Also rename `receive_window` to `receive_window_remaining` so the
peak/remaining distinction is clear at the call site, and document
that `:receive_window_update_threshold` is shared between the
connection and per-stream windows (so windows at or below the
threshold refill on every DATA frame).

Pull Request Pull Request #481: Raise default HTTP/2 receive windows and batch HTTP/2 receive-window refills

Coverage Stats

81 of 86 new or added lines in 1 file covered. (94.19%)

36 existing lines in 1 file now uncovered.

1353 of 1535 relevant lines covered (88.14%)

245.82 hits per line