babelfish-for-postgresql / babelfish_extensions / 24357334659

77%

BABEL_6_X_DEV: 77%

Build Type

push

github

Committed by web-flow

Commit Message

Fix Invalid Read in IsTopTransactionName (#4717) (#4724)

SetTopTransactionName() stores the transaction name in TopTransactionContext
memory. When the transaction ends, this memory is freed but the name pointer
is not set to NULL, leaving a dangling pointer. A subsequent call to
IsTopTransactionName() then reads freed memory via strcmp().

Introduce ResetTopTransactionName() which NULLs out name. This is called from
pltsql_xact_cb to ensure the pointer is reset on every transaction end.

Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#739

Task: BABEL-5245

Authored-by: Rucha Kulkarni ruchask@amazon.com

Coverage Stats

2 of 2 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

53285 of 69082 relevant lines covered (77.13%)

406833.92 hits per line