zopefoundation / ZODB / 24341287169

84%

master: 84%

Build Type

Pull #421

github

Committed by perrinjerome

Commit Message

Add class_factory parameter to DB and ZConfig class-factory option

DB.__init__() opens a connection to verify the root object exists,
and that connection is returned to the pool for future reuse.
Connections capture the classFactory reference at creation time
(in Connection.__init__ via ObjectReader), so setting db.classFactory
after DB.__init__() does not apply to connections already in the pool.

This is a problem for Zope, which overrides DB.classFactory after
construction to provide graceful handling of broken/uninstalled objects.
The first connection handed out after startup may silently use the
wrong class factory.

Add a class_factory parameter to DB.__init__() that is set before any
connection is opened, and a corresponding class-factory option to the
ZConfig database configuration schema. This allows frameworks like
Zope to pass the class factory at construction time.

Pull Request Pull Request #421: Add class_factory parameter to DB and ZConfig class-factory option

Coverage Stats

2445 of 3546 branches covered (68.95%)

15 of 18 new or added lines in 4 files covered. (83.33%)

24 existing lines in 1 file now uncovered.

13370 of 15956 relevant lines covered (83.79%)

0.84 hits per line