zopefoundation / ZODB

84%

master: 84%

LAST BUILD ON BRANCH perrinjerome/classFactory

branch: SELECT

CHANGE BRANCH

x

• No branch selected
• 3.10.7
• 350-fix-bytes-vs-text
• 5.0.1
• 5.1.0
• 5.1.1
• 5.2.0
• 5.2.1
• 5.2.2
• 5.2.3
• 5.2.4
• 5.3.0
• 5.4.0
• 5.5.0
• 5.5.1
• 5.6.0
• 5.7.0
• 5.8.0
• 5.8.1
• 6.0
• 6.0.1
• 6.1
• 6.2
• add-py38
• agroszer-clean-leaks
• agroszer-typo
• all-repos_autofix_all-repos-sed
• appveyor
• appveyor-mock
• be-less-negative
• blob-default-permissions
• blob_tests
• bytes_for_all_tids
• cleanup-check_checkCurrentSerialInTransaction
• closure
• config-with-pure-python
• config-with-pure-python-template-12d1a05d
• config-with-pure-python-template-1404d28b
• config-with-pure-python-template-6f887812
• config-with-pure-python-template-b21fbbf2
• config-with-pure-python-template-b3663390
• config-with-pure-python-template-babc889c
• config-with-pure-python-template-f6df9072
• coveralls
• data-for-TransactionMetaData-and-TransactionRecord
• dataflake/gh-actions
• dataflake/setup_py_to_pyproject_toml
• davisagli-pack-error-oid
• doc-292-volatile-attributes
• drop-pkg_resources
• drop34
• extension_bytes
• faster-bush-oid-to-path
• feature/faster-tests
• fix-py310-deprecation-warnings
• fix-recursion
• fix_UnboundLocalError
• fix_memleak_with_closed_connections
• fix_racetests
• fixup-pr307
• fsdump_fsstats#354
• get-ghost
• handle_serial
• import-no-seeks
• issue-119
• issue-138
• issue-139
• issue158
• issue213
• issue214
• issue216
• issue263
• issue266
• issue268
• issue282
• issue290
• issue78
• jam-pickle-prot
• jam-zodbshootout-26
• jamadden-patch-1
• master
• merge-zodbdocs
• no-sphinx-on-3.3
• only-new-style
• perrinjerome/classFactory
• perrinjerome/fix/restore_wrong_prev_txn
• perrinjerome/repozo-ignored-warning
• perrinjerome/repozo-recover-stdout
• prep-5.5.0-release
• prep-5.5.1-release
• pure-python-tests
• pypi
• python3-compatible-persistent-refs
• python311
• python36
• racetest
• remove-obsolete
• repozo-better-error
• repozo-incremental-recover
• repozo-verify-exit-code
• rotonen-bump-pypy
• storage-afterCompletion
• storage-afterCompletion2
• storage-byte-appreciation
• sunew-failing-test-for-208
• tour
• transaction30
• tseaver-drop_setup_py_test_fossils
• update-zodbpickle
• weakset
• y/check_race-spec
• y/flakes
• y/fs1-recover-seek-fix
• y/goodbye-warnhook
• y/kill-positive_id
• y/zope-testrunner-a1000
• z-object-database
• zope-interface-fix-inconsistent-iro

Build # 23421885197

Build Type

Pull #421

github

Committed by perrinjerome

Commit Message

Add class_factory parameter to DB and ZConfig class-factory option

DB.__init__() opens a connection to verify the root object exists,
and that connection is returned to the pool for future reuse.
Connections capture the classFactory reference at creation time
(in Connection.__init__ via ObjectReader), so setting db.classFactory
after DB.__init__() does not apply to connections already in the pool.

This is a problem for Zope, which overrides DB.classFactory after
construction to provide graceful handling of broken/uninstalled objects.
The first connection handed out after startup may silently use the
wrong class factory.

Add a class_factory parameter to DB.__init__() that is set before any
connection is opened, and a corresponding class-factory option to the
ZConfig database configuration schema. This allows frameworks like
Zope to pass the class factory at construction time.

Pull Request Pull Request #421: Add class_factory parameter to DB and ZConfig class-factory option

Run Details

2444 of 3546 branches covered (68.92%)

14 of 17 new or added lines in 4 files covered. (82.35%)

13367 of 15955 relevant lines covered (83.78%)

0.84 hits per line