kobotoolbox / kpi / 24329886474

82%

master: 76%

push

github

fix(formBuilder): don't modify existing text operators DEV-1891  (#6921)

### 📣 Summary

`text` questions with comparison operators will no longer get their
conditions modified (unknowlingy!) when saving in Form Builder.

### 💭 Notes

Changes here:
- Added tests to verify code bug is fixed
- Changed how we handle operators

### 👀 Preview steps

1. ℹ️ Import test form 
[Text Relevance
Bug.xlsx](https://github.com/user-attachments/files/26509637/Text.Relevance.Bug.xlsx),
no need to deploy it
2. Open new tab at `/#/forms/<uid>/json` (let's call it "Tab A" - for
comparison later, don't refresh it)
3. Open "Text Relevance Bug" project in Form Builder
4. Click "Save"
5. Open new tab at `/#/forms/<uid>/json` (let's call it "Tab B")
6. 🔴 [on main] notice that Tab A and Tab B have different content (e.g.
for `note_text_bug_less` `relevant` changed to `${age_text} != ''`
7. 🟢 [on PR] notice that Tab A and Tab B have not changed (e.g. for
`note_text_bug_less` `relevant` is still `${age_text} < 18`)

---------

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

7823 of 12035 branches covered (65.0%)

29760 of 36195 relevant lines covered (82.22%)

5.79 hits per line