24228026749
81%

Ran 10 Apr 2026 06:34AM UTC

Jobs 1

Files 63

Run time 1min

Badge

Embed ▾

Committed 09 Apr 2026 02:28PM UTC coverage: 83.103% (+0.06%) from 83.041%

Build # 24228026749

Build Type

push

github

Committed by

web-flow

Commit Message

[FIXED] Stream leader can catchup from snapshot if required (#8021)

After scaling up a stream, a follower could have received a snapshot
(through `SendSnapshot`) but not have caught up from it. Based on its
log it could already become the new stream leader. When it got to
`processSnapshot` it would error with `errAlreadyLeader` due to
`n.PauseApply()` and then skip catchup.

This PR fixes that by always processing the incoming snapshot, even if
we're leader, since we check that we're up-to-date first and otherwise
step down and perform catch up. This will usually not happen on a
leader, but can happen under certain edge cases during scale up.

Resolves https://github.com/nats-io/nats-server/issues/8020

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>

Coverage Stats

75953 of 91396 relevant lines covered (83.1%)

346121.55 hits per line

Coverage Regressions

Lines	Coverage	∆	File
881	78.49	0.58%	src/github.com/nats-io/nats-server/server/filestore.go
740	78.51	0.3%	src/github.com/nats-io/nats-server/server/opts.go
580	82.03	0.01%	src/github.com/nats-io/nats-server/server/jetstream_cluster.go
529	74.32	-0.24%	src/github.com/nats-io/nats-server/server/jetstream_api.go
473	87.93	-0.11%	src/github.com/nats-io/nats-server/server/consumer.go
464	85.71	-0.23%	src/github.com/nats-io/nats-server/server/stream.go
445	85.79	-0.44%	src/github.com/nats-io/nats-server/server/raft.go
203	86.39	0.01%	src/github.com/nats-io/nats-server/server/events.go
188	81.52	0.16%	src/github.com/nats-io/nats-server/server/memstore.go
157	87.55	-0.06%	src/github.com/nats-io/nats-server/server/monitor.go
68	89.79	0.28%	src/github.com/nats-io/nats-server/server/server.go
3	90.31	0.07%	src/github.com/nats-io/nats-server/server/leafnode.go
2	86.88	0.0%	src/github.com/nats-io/nats-server/server/accounts.go
2	93.51	0.0%	src/github.com/nats-io/nats-server/server/client.go
2	84.12	-0.08%	src/github.com/nats-io/nats-server/server/route.go
2	86.46	-0.87%	src/github.com/nats-io/nats-server/server/util.go
1	90.21	0.0%	src/github.com/nats-io/nats-server/server/jetstream_batching.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	24228026749.1	10 Apr 2026 06:34AM UTC	63	83.1	GitHub Action Run

nats-io / nats-server / 24228026749
81%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 24228026749

nats-io / nats-server / 24228026749 81%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 24228026749

nats-io / nats-server / 24228026749
81%

README BADGES
x