RobotWebTools / rclnodejs / 24229260424

86%

push

github

Treat unrecognized ROS_DISTRO as a future distro (#1485)

Previously, `getDistroId()` returned `UNKNOWN (0)` for any `ROS_DISTRO` value not in the known map. This caused forward-looking feature guards (e.g., `>= ROLLING`) to fail for future distros like "lyrical", even though they would include the same ABI changes as Rolling.

Now, if `ROS_DISTRO` is set but not recognized, `getDistroId()` returns `FUTURE (9999)` instead, so feature guards pass correctly. If `ROS_DISTRO` is unset, it still returns `UNKNOWN (0)`.

### Changes

- **lib/distro.js**
  - Added `FUTURE: 9999` to `DistroId` enum
  - Updated `getDistroId()` to return `FUTURE` when `ROS_DISTRO` is set but not in the known map, `UNKNOWN` when unset

- **test/test-distro.js**
  - Updated "unknown distro" test to expect `FUTURE` for unrecognized `ROS_DISTRO` values
  - Added assertion for truly unset `ROS_DISTRO` returning `UNKNOWN`

Fix: #1484

1566 of 1985 branches covered (78.89%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

3179 of 3541 relevant lines covered (89.78%)

448.39 hits per line