JuliaLang / julia / 1498

78%

Build Type

push

buildkite

Committed by web-flow

Commit Message

inference: Respect `@nospecializeinfer` semantics in constant prop (#61502)

`@nospecializeinfer` widens the `MethodInstance` signature so that
inference does not specialize on `@nospecialize`'d arguments, but const
prop was not respecting this and `matching_cache_argtypes` would expand
a `Vararg` in the `MI`'s `cache_argtypes` to match the call-site arity,
producing `argtypes` of different lengths for different const-prop call
sites sharing the same `MI`. This caused an assertion failure in
`constprop_cache_lookup` when a second call with a different number of
varargs tried to look up a cached result.

Fix this by widening the `@nospecialize`'d arguments back to the
`cache_argtypes`, using the same `nospecialize` bitmask convention as
`jl_compilation_sig` in `src/gf.c`.
This ensures constprop argtypes always have the same shape as the `MI`'s
baseline argtypes, and avoids unnecessary specialization that
contradicts the intent of `@nospecializeinfer`.

Fixes aviatesk/JETLS.jl#618.

Coverage Stats

11 of 11 new or added lines in 2 files covered. (100.0%)

379 existing lines in 13 files now uncovered.

64988 of 83567 relevant lines covered (77.77%)

23168802.99 hits per line