kubeovn / kube-ovn / 24137916977

25%

push

github

fix(daemon): reorder SR-IOV representor lifecycle to prevent CmdAdd/CmdDel race (#6593)

* fix(daemon): reorder SR-IOV representor lifecycle to prevent CmdAdd/CmdDel race

Reorder LinkSetUp and LinkSetMTU on the SR-IOV VF representor so they
execute after OVS add-port instead of before, closing the window where
a concurrent CmdDel on the same VF could interfere with the representor
before it is attached to br-int.

Changes:
- renameLink: no longer calls LinkSetUp; representor stays DOWN after rename
- setupSriovInterface: remove LinkSetMTU (deferred to configureNic)
- configureNic: set MTU after add-port; configureHostNic then brings link UP
- deleteNic: LinkSetDown the representor before del-port
- Add deferred rollback to bring representor back UP on CmdAdd failure

Upstream reference: https://github.com/ovn-org/ovn-kubernetes/pull/6106

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

* fix(daemon): use input string in MAC parse error message

Use the original mac input string with %q format instead of the parsed
macAddr result, which is nil on ParseMAC failure and produces an empty
error message.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

---------

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

0 of 26 new or added lines in 1 file covered. (0.0%)

13663 of 56148 relevant lines covered (24.33%)

0.28 hits per line