kubeovn / kube-ovn / 24131055659

24%

push

github

fix: add SplitTrimmed to prevent index out of range and empty token propagation (#6592)

* fix: add SplitTrimmed to prevent index out of range and empty token propagation

Add util.SplitTrimmed() that splits strings, trims whitespace, and
filters empty tokens. Replace bare strings.Split/SplitSeq calls across
14 sites in daemon and controller packages to defend against malformed
comma-separated IP/gateway annotations containing trailing commas,
leading commas, or extra whitespace.

The primary fix is in waitNetworkReady() where two Split results were
iterated in parallel without length validation, risking index out of
range panic when gateway elements outnumber IP elements. Also normalize
BFDPort status IP to prevent downstream SplitStringIP/CheckProtocol
failures when spec contains whitespace.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

* fix: add empty slice guards after SplitTrimmed for egress gateway parsing

SplitTrimmed returns nil for empty/whitespace-only input, unlike
strings.Split which returns [""] (length 1). Add len(egw) == 0 guards
at three call sites that directly index egw[0] to prevent index out of
range panic on malformed ExternalEgressGateway values.

Addresses Copilot review feedback on PR #6592.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

---------

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

15 of 34 new or added lines in 5 files covered. (44.12%)

13663 of 56134 relevant lines covered (24.34%)

0.28 hits per line